Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statements, tidb-configuration-file: refine the document about expression index #6643

Merged
merged 29 commits into from
Aug 13, 2021
Merged

sql-statements, tidb-configuration-file: refine the document about expression index #6643

merged 29 commits into from
Aug 13, 2021

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jul 8, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

wjhuang2016 and others added 2 commits July 8, 2021 13:56
@wjhuang2016 @TomShawn
*: remove expression index out of experimental feature. (pingcap#4641)
a0dca2e 
* done

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

* fmt

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016
init
3262b79 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 8, 2021 06:21
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@wjhuang2016 wjhuang2016 added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
TomShawn
TomShawn previously approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jul 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 8, 2021
@wjhuang2016
Copy link
Member Author

wjhuang2016 commented Jul 8, 2021 •
edited
Loading

This document is not finished yet.

@TomShawn TomShawn dismissed their stale review July 8, 2021 06:36

pr not finished

@wjhuang2016
done
9f2b77a 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' of github.com:pingcap/docs-cn into expression_i…
a76bdcc 
…ndex_ga
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2021
@wjhuang2016 wjhuang2016 added v5.2 This PR/issue applies to TiDB v5.2. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 9, 2021
@wjhuang2016
lint
5b33eb9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
lint
2d229c7 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
lint
08998d7 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
lint
1e84643 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
lint
b30b447 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
1
3d308d7 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
1
4066262 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
1
e56bc3a 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@TomShawn
Copy link
Contributor

TomShawn commented Aug 9, 2021

@wjhuang2016 Please involve one or two tech reviewers. Thanks!

bb7133
bb7133 reviewed Aug 9, 2021
View reviewed changes
tidb-configuration-file.md Outdated
@@ -636,9 +636,4 @@ TiDB 服务状态相关配置。

## experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete the ‘experimental' part? I don't think it will be used in the future.

wjhuang2016 and others added 6 commits August 10, 2021 16:51
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-create-index.md
46c8098 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-create-index.md
48d6000 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-create-index.md
b6dd2fb 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-create-index.md
d90a4b9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016
fix
0a1952b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
0b70f80 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@TomShawn
Copy link
Contributor

Rest LGTM
@bb7133 PTAL

@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-create-index.md
f42d85a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Aug 10, 2021
@qiancai
Copy link
Collaborator

qiancai commented Aug 12, 2021

/cc @together-wang

@together-wang
Copy link
Contributor

LGTM

@TomShawn
Copy link
Contributor

@wjhuang2016 Please resolve the conflict. Thanks!

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 56a2449

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot ti-chi-bot merged commit fc85fca into pingcap:master Aug 13, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 17, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 17, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 19, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en-jin19 en-jin19 en-jin19 left review comments

@TomShawn TomShawn TomShawn left review comments

@tangenta tangenta tangenta approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@together-wang together-wang Awaiting requested review from together-wang

Assignees

@en-jin19 en-jin19

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wjhuang2016 @ti-chi-bot @TomShawn @qiancai @together-wang @bb7133 @tangenta @en-jin19